Add check for pyenv_custom_pyenvrc_file #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks to only add custom pyenvrc sourcing if it was defined. Similarly to how `Install custom .pyenvrc` checks for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small change: it checks for
pyenv_custom_pyenvrc_fileinto the mainpyenvrctemplate.Does not change functionality, as the sourcing of the custom pyenvrc file is behind a check.
However, it can lead someone astray when reading or debugging a pyenv system.
Additionally if someone would remove the
pyenv_custom_pyenvrc_filefrom the role vars, the configuration would still apply (since the main config always checks for the file's existance).