V5 (WIP) #898
Merged
V5 (WIP) #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d3d6149 The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3555928:
|
davidkpiano
commented
Aug 5, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d3d6149:
|
Andarist
force-pushed
the
next
branch
3 times, most recently
from
0c89c96
to
98a7202
Compare
Andarist
force-pushed
the
next
branch
3 times, most recently
from
9f12764
to
8528b6c
Compare
* Drop support for `TransitionsConfigArray` * fix types + test * add more tests * add changeset
…tored and resolved (#4127) * Refactor builtin actions in order to remove the fake callable signature * Declassify the builtin actions * Fix and cleanup types * add extra type tests to raise * Provide `action` to action implementations again * Bring back .type for builtins * Convert string action to an object form when creating action args * Temporarily serialize~ actions in machine definition to pass JSON schema test * Fixed `.after` cancellation * Hoist `toSerializableActon` * add changeset * Remove outdated comment
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
# Conflicts: # packages/core/CHANGELOG.md # packages/core/package.json # packages/core/src/actions.ts # packages/core/src/index.ts # packages/core/src/types.ts # packages/core/test/actions.test.ts # packages/xstate-analytics/package.json # packages/xstate-graph/package.json # packages/xstate-immer/package.json # packages/xstate-inspect/package.json # packages/xstate-react/package.json # packages/xstate-scxml/package.json # packages/xstate-solid/package.json # packages/xstate-svelte/package.json # packages/xstate-test/package.json # packages/xstate-vue/package.json
* Require machine context if defined * Oops * Update packages/core/src/types.ts Co-authored-by: Mateusz Burzyński <[email protected]> * Okay Svelte * Fix types * Fix tests * Add changeset * Revert irrelevant files --------- Co-authored-by: Mateusz Burzyński <[email protected]>
* Add self to promise * Add self for transitions * Add self to observable + event observable * Add self to callbacks * Fix type * Add changeset * Update .changeset/orange-pillows-deny.md Co-authored-by: Mateusz Burzyński <[email protected]> * Add test + onSnapshot support for transition actors * Revert "Add test + onSnapshot support for transition actors" This reverts commit 542b37d. * Add test * Fix types * Update packages/core/src/types.ts Co-authored-by: Mateusz Burzyński <[email protected]> --------- Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* POC for actor types * Remove patterns.ts * Fix types sorta * Remove ActorMap * Add changeset * Improve state.children * Add InputFrom and actor behavior input * Types WIP * PromiseActorEvents * Undo * Fix most type errors * Get types passing * Update packages/xstate-solid/test/useMachine.test.tsx Co-authored-by: Mateusz Burzyński <[email protected]> * Change changeset * Fix types * Fix test type * Clean up ActorImpl types * Fix import * Fix import * Fix * Tweak how `TActors` are passed around * Stick to the `.logic` prop * add some type tests for actor types * tweak things * Removed TActions from state * Fix Svelte type issues * Add `TInput` to `TransitionActorLogic` * tweak small things * require actor IDs when they are configured * small tweaks * Tweak changeset * Tweak how actor type is distributed in `InvokeConfig` * disallow inline actors when the actor type is provided * Fix `GenerateActorEvents` * Fixed `TInvokeSrcNameMap` usage in `GenerateActorEvents` * fixed tests * Add comments explaining `GenerateActorEvents` * fixed test * remove old hack * Compute `State['children']` more accurately * fixed ComputeChildren type * Add test and fix the children being a union --------- Co-authored-by: Mateusz Burzyński <[email protected]>
* Strongly type state value * Satisfy the typegen * small tweaks * Pass around `TStateValue` instead of `TConfig` * Type `MachineSnapshot<...>['value']` correctly * remove code related to typegen and `state.matches` * remove outdated comment * first stab at `ToTestStateValue` * add some extra ts-expect-errors * cast `machineSnapshotMatches` * Fixed `ToTestStateValue` * add missing initial property * Revert "remove code related to typegen and `state.matches`" This reverts commit 6e19c9a. * support typegen * Fixed assertions in typegen tests * add more test cases, fix one case --------- Co-authored-by: Mateusz Burzyński <[email protected]>
* Refactor callback logic to not send self-event * Changeset * Attach to scope so @Andarist can fix it later * use a `WeakMap` to keep callback instance around * deduplicate observable event types * unify promise event types with the convention used elsewhere * add a tets case --------- Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update templates * Update to latest
* Further errors-related adjuments * tweak tests and comments * add changeset * Update .changeset/olive-months-shave.md Co-authored-by: David Khourshid <[email protected]> --------- Co-authored-by: David Khourshid <[email protected]>
…-less actors (#4523) * Fixed an issue with contextual parameters in input factories of input-less actors * Changeset --------- Co-authored-by: David Khourshid <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* createAction POC * Add guard evaluation * Goodbye, pure and choose * exec -> enqueue * Rename to enqueueActions * More renaming * fixed types * move `enqueueActions` to its own file and tweak the related types * Reimplement `pure` using `enqueueActions` * `guard` -> `check` * Add changeset * revert test changes * add tests * Remove `PureAction` reference * add type tests * fixed a typo --------- Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update after events * Changeset * Use more predictable generated IDs * Update packages/core/src/utils.ts Co-authored-by: Mateusz Burzyński <[email protected]> * Adjust after event types and invoke IDs further (#4524) * drop one extra hash * Update .changeset/weak-swans-care.md --------- Co-authored-by: Mateusz Burzyński <[email protected]>
* Remove xstate-analytics * remove moar files --------- Co-authored-by: Mateusz Burzyński <[email protected]>
* Fixed order of type parameters in `ActorRef` * Changeset --------- Co-authored-by: David Khourshid <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Rename `state` to `snapshot` in many variables and signatures * Rename snapshot-related methods on the logic * Deprecate options.state * Changeset --------- Co-authored-by: David Khourshid <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* For onError, rename event.data -> event.error * Changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a placeholder PR for the ongoing V5 work.