Fixed ToProvidedActor helper type (#4499)

* Add failing test * Fixed `ToProvidedActor` helper * simplify test to avoid a runtime error * add changeset --------- Co-authored-by: Mateusz Burzyński <[email protected]>
statelyai · Nov 27, 2023 · c9908b7 · c9908b7
1 parent ba4e8b3
commit c9908b7
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/.changeset/fix-toprovidedactor.md b/.changeset/fix-toprovidedactor.md
@@ -0,0 +1,5 @@
+---
+'xstate': patch
+---
+
+Fixed the `TActor` type passed down by `setup` in absence of provided actors.
diff --git a/packages/core/src/setup.ts b/packages/core/src/setup.ts
@@ -43,11 +43,15 @@ type DefaultToAnyActors<TActors extends Record<string, AnyActorLogic>> =
 // this could be reconsidered in the future
 type ToProvidedActor<
   TChildrenMap extends Record<string, string>,
-  TActors extends Record<Values<TChildrenMap>, AnyActorLogic>
+  TActors extends Record<Values<TChildrenMap>, AnyActorLogic>,
+  TResolvedActors extends Record<
+    string,
+    AnyActorLogic
+  > = DefaultToAnyActors<TActors>
 > = Values<{
-  [K in keyof DefaultToAnyActors<TActors> & string]: {
+  [K in keyof TResolvedActors & string]: {
     src: K;
-    logic: TActors[K];
+    logic: TResolvedActors[K];
     id: IsNever<TChildrenMap> extends true
       ? string | undefined
       : K extends keyof Invert<TChildrenMap>

diff --git a/packages/core/test/setup.types.test.ts b/packages/core/test/setup.types.test.ts
@@ -923,4 +923,14 @@ describe('setup()', () => {
       | ActorRefFrom<typeof child2>
       | undefined;
   });
+
+  it('should accept `assign` when no actor and children types are provided', () => {
+    setup({}).createMachine({
+      on: {
+        RESTART: {
+          actions: assign({})
+        }
+      }
+    });
+  });
 });