Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added runme via ssh #231

Merged
merged 27 commits into from
Oct 19, 2023
Merged

added runme via ssh #231

merged 27 commits into from
Oct 19, 2023

Conversation

edeediong
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-runme-dev ✅ Ready (Inspect) Visit Preview ✅ 3 resolved Oct 19, 2023 7:59pm

@edeediong edeediong marked this pull request as draft October 12, 2023 06:31
@edeediong edeediong marked this pull request as ready for review October 13, 2023 05:14
@sourishkrout
Copy link
Member

@edeediong can we replace the Oracle links with GitHub ones for the key generation etc? Also, the CLI examples are good start. However, I'd like to feature the "VS Code Remote Development" showcase on top of the page: https://code.visualstudio.com/docs/remote/ssh

This is where you attach VS Code to the SSH host and use the notebook UX on the remote machine as if it ran locally.

Also not clear why the deploy fails... says "broken links" in Vercel. I'll add you to the Vercel site.

@sourishkrout
Copy link
Member

@edeediong I dropped some comments on the preview site at https://docs-runme-dev-git-runmessh-stateful.vercel.app/ (be sure to log into vercel please).

@sourishkrout
Copy link
Member

sourishkrout commented Oct 17, 2023 •
edited
Loading

Can you break down the header in a way so that they show up in the right hand nav please?

image

@edeediong ☝️

@sourishkrout
Copy link
Member

sourishkrout commented Oct 17, 2023 •
edited
Loading

Also for the connecting using Remote Dev via SSH, let's do step by step screenshots. It's easy to overlook the point of the "feature" otherwise.

image

Essentially have a screenshot per item in the enumerated list of steps @edeediong.

@sourishkrout sourishkrout merged commit 83d1fc5 into main Oct 19, 2023
2 checks passed
@sourishkrout sourishkrout self-requested a review October 19, 2023 19:59
@sourishkrout
Copy link
Member

👍 LGTM

@sourishkrout sourishkrout deleted the runmessh branch October 19, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout Awaiting requested review from sourishkrout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edeediong @sourishkrout