Only enable used Bard buttons #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of clearing the blueprint directory upon test setup seems to have broken this test. Slightly re-working it seems to make them pass again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you import a Bard field, the importer will automatically enable various Buttons on the Bard field, so you don't see errors like this when viewing imported entries in the Control Panel:
This was fine. It meant you didn't encounter those errors - well, unless your content needed a button that wasn't enabled by default, in which case you'd need to enable the button manually.
However, it always felt a bit janky, especially if your imported content only needed something like bold or italic, but we also enabled images for you.
This pull request improves it, by only enabling the buttons needed for the content you've imported.
Closes #72.