Show warning banner when database isn't configured #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
duncanmcclean
deleted the
show-warning-banner-when-db-isnt-configured
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prevents an error from occuring when the Importer can't connect to the app's database (for example: when the SQLite database file hasn't been created).
Instead of seeing an error as soon as you go to the edit page, you'll now see a banner asking you to migrate your database, which will let you configure your application's database:
You'll only be able to run the import after migrating the database tables.
Combined with recent updates to the docs, these changes should make the next steps a little more obvious when you're running into database-related errors.
Related: #55