Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we store the latest Entry uri #392

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Ensure we store the latest Entry uri #392

merged 2 commits into from
Dec 12, 2024

Conversation

ryanmitchell
Copy link
Contributor

This PR updates entry saving to use the routableUri, not the uri, which ensures we always have the latest uri in the database, even when the entry is new or when the slug is changed.

Closes #391

@ryanmitchell ryanmitchell marked this pull request as draft December 10, 2024 21:56
@kram-dyoll
Copy link

kram-dyoll commented Dec 11, 2024 •
edited
Loading

@ryanmitchell That worked as expected. The slug and uri fields were both updated at the same time and resulted in the new URL working first time.

Thank you

@ryanmitchell ryanmitchell marked this pull request as ready for review December 12, 2024 06:52
@ryanmitchell ryanmitchell merged commit d5874bb into statamic:master Dec 12, 2024
13 checks passed
@ryanmitchell ryanmitchell deleted the fix/entry-uri branch December 12, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entry slug URI not updating on save
2 participants
@ryanmitchell @kram-dyoll