Update entry URIs when collection route is changed #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but will only work if you have both collection and entries eloquent driven. If you have collections file driven, then this wouldn't update the eloquent entries with the new route (which I'd guess is the more common config). Maybe we are ok with that, but thought I'd mention it for discussion. |
|
Oh, good point! Ideally, it'd work if your collections were stored as flat files too. I'll have a think about the best way to approach it 🤔 |
|
Closing in favour of statamic/cms#11150. |
duncanmcclean
deleted the
update-entry-uris-when-collection-route-is-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue when changing a collection's route, where it wouldn't trigger the
uricolumn on theentriestable to be updated.Closes #378.