[4.x] Fix tables in Bard not saving updates #9867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksleight
changed the title
|
You're a clever guy |
|
Ha, it made my head melt a bit 🫠 . |
|
Still a bit of a mystery why this is only happening with table fields. Seems like it should happen with all fields but it doesn't... weird. |
|
Amazing Jack! Thanks for this! @websmyth kept suggesting this was all my fault. |
|
Flipping heck, @jacksleight - amazing work! @robdekort I'm still blaming you, ok 😂 |
|
Sorry @websmyth, turns out it was my fault! But I'm happy for you to blame @robdekort 😄 . @jasonvarga I'm wondering if there might be another way to handle all this in v5 with the other json encoding changes. I might look at that separately. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9860
This was caused by the change in #9788.
Tiptap isn't (always?) creating new objects when
onUpdatefires orgetJSONis called, so after the first updateoldJsonis exactly the same object asjson, the comparison passes, and no further updates are fired.This wasn't a problem before #9788 because it was comparing against
this.valuewhich was already stringified in the previous update.