Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Prevent showing "Saved" toast message when listener cancels save #9040

Merged

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Nov 20, 2023

This pull request fixes an issue where a successful "Saved" toast message would be displayed after cancelling the save with the EntrySaving event.

This fix also applies to some of the other Saving events.

Fixes #6293.

To Do

  • Entries
    • EntrySaving
    • RevisionSaving
  • TermSaving
  • GlobalSetSaving
  • UserSaving

@duncanmcclean duncanmcclean marked this pull request as ready for review November 21, 2023 13:55
@jackmcdade jackmcdade merged commit f2c7b51 into 4.x Dec 1, 2023
37 checks passed
@jackmcdade jackmcdade deleted the fix/saved-toast-showing-even-when-save-was-prevented branch December 1, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control Panel will still show Saved toast when returning false from EntrySaving listener
2 participants