Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Prevent ensuring fields on entries if they already exist #8926

Merged

Conversation

duncanmcclean
Copy link
Member

This pull request prevents fields from being ensured on entry blueprints if they already exist. Without this check, any changes you made to the config of any of the ensured fields would be overwritten the next time you save the blueprint.

I've added the check for this in Collection where we're ensuring them but happy to do something "upstream" (eg. in the Blueprint methods) if you'd rather go down that route.

Fixes #2743.

@duncanmcclean duncanmcclean changed the title Prevent ensuring fields on entries if they already exist [4.x] Prevent ensuring fields on entries if they already exist Nov 3, 2023
@jasonvarga jasonvarga merged commit 176d716 into 4.x Nov 6, 2023
36 of 37 checks passed
@jasonvarga jasonvarga deleted the fix/unable_to_unlocalize_slug_in_the_blueprint_builder branch November 6, 2023 20:49
@jasonvarga
Copy link
Member

jasonvarga commented Nov 30, 2023

This is reverted in #9094. It broke date fields a little.

The aim of this PR was to fix #2743 but it looks like the issue doesn't happen anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to unlocalize slug in the blueprint builder
2 participants