Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix missing translation of some user defined strings #8914

Merged
merged 3 commits into from
Nov 2, 2023
Merged

[4.x] Fix missing translation of some user defined strings #8914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180a3b2
Missing some missing user defined translations
ryanmitchell Nov 2, 2023
82c9a0c
Taxonomy listing too
ryanmitchell Nov 2, 2023
749974d
Missing heading translations
ryanmitchell Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/js/components/collections/Listing.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="card overflow-hidden p-0" slot-scope="{ filteredRows: rows }">
<data-list-table :rows="rows">
<template slot="cell-title" slot-scope="{ row: collection }">
<a :href="collection.entries_url">{{ collection.title }}</a>
<a :href="collection.entries_url">{{ __(collection.title) }}</a>
</template>
<template slot="actions" slot-scope="{ row: collection, index }">
<dropdown-list placement="left-start">
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/collections/View.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<breadcrumb :url="breadcrumbUrl" :title="__('Collections')" />

<div class="flex items-center">
<h1 class="flex-1" v-text="title" />
<h1 class="flex-1" v-text="__(title)" />

<dropdown-list class="mr-2" v-if="!!this.$scopedSlots.twirldown">
<slot name="twirldown" />
Expand Down
4 changes: 2 additions & 2 deletions resources/js/components/data-list/Table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
</td>
<td class="type-column" v-if="type">
<span v-if="type === 'entries' || type === 'terms'" class="rounded px-1 py-px text-2xs uppercase bg-gray-200 text-gray">
<template v-if="type === 'entries'">{{ row.collection.title }}</template>
<template v-if="type === 'terms'">{{ row.taxonomy.title }}</template>
<template v-if="type === 'entries'">{{ __(row.collection.title) }}</template>
<template v-if="type === 'terms'">{{ __(row.taxonomy.title) }}</template>
</span>
</td>
<th class="actions-column">
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/globals/PublishForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<breadcrumb :url="globalsUrl" :title="__('Globals')" />

<div class="flex items-center">
<h1 class="flex-1" v-text="title" />
<h1 class="flex-1" v-text="__(title)" />

<div class="pt-px text-2xs text-gray-600 ml-4 flex" v-if="! canEdit">
<svg-icon name="lock" class="w-4 mr-1 -mt-1" /> {{ __('Read Only') }}
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/inputs/relationship/Item.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
/>

<div class="flex items-center flex-1 justify-end">
<div v-if="item.collection" v-text="item.collection.title" class="text-4xs text-gray-600 uppercase whitespace-nowrap mr-2 hidden @sm:block" />
<div v-if="item.collection" v-text="__(item.collection.title)" class="text-4xs text-gray-600 uppercase whitespace-nowrap mr-2 hidden @sm:block" />

<div class="flex items-center" v-if="!readOnly">
<dropdown-list>
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/navigation/View.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<breadcrumb :url="breadcrumbUrl" :title="__('Navigation')" />

<div class="flex items-center">
<h1 class="flex-1" v-text="title" />
<h1 class="flex-1" v-text="__(title)" />

<dropdown-list class="mr-2">
<slot name="twirldown" />
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/taxonomies/Listing.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="card p-0" slot-scope="{ filteredRows: rows }">
<data-list-table :rows="rows">
<template slot="cell-title" slot-scope="{ row: taxonomy }">
<a :href="taxonomy.terms_url">{{ taxonomy.title }}</a>
<a :href="taxonomy.terms_url">{{ __(taxonomy.title) }}</a>
</template>
<template slot="actions" slot-scope="{ row: taxonomy, index }">
<dropdown-list placement="left-start">
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/user-groups/PublishForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<header class="mb-3">
<breadcrumb :url="cp_url('user-groups')" :title="__('User Groups')" />
<div class="flex items-center">
<h1 class="flex-1" v-text="title" />
<h1 class="flex-1" v-text="__(title)" />
<dropdown-list class="mr-2" v-if="canEditBlueprint">
<dropdown-item :text="__('Edit Blueprint')" :redirect="actions.editBlueprint" />
</dropdown-list>
Expand Down
Loading