[4.x] Don't create revision when localizing entry unless revisions are enabled on the collection #8908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Jan 17, 2024
src/Http/Controllers/CP/Collections/LocalizeEntryController.php
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Http/Controllers/CP/Collections/LocalizeEntryController.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a revision would be created when localizing an entry, even when revisions were disabled on the entry's collection.
This PR also deprecates the
revisionsmethod on theCollectionin favour of therevisionsEnabledmethod which does the same thing (+ an additional check to see if the Revisions feature is enabled and if the site is running Pro).It also adjusts the
revisionsEnabledcondition on theRevisabletrait that was incorrect - probably a copy/paste error in 04aaf5c.Fixes #3117.