Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Fix CP nav item active status regressions #8880

Merged
merged 29 commits into from
Nov 1, 2023
Merged

[4.x] Fix CP nav item active status regressions #8880

merged 29 commits into from
Nov 1, 2023

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Oct 25, 2023 •
edited
Loading

Closes #8760
References #8273
References #8685

@jesseleite
Whoops, this isn’t needed anymore.
b8d0361
@jesseleite
Ensure we cache explicit cp nav urls for isActive() checks on unres…
09d5b48 
…olved closures.
@jesseleite
Refactor isActive() logic.
85462c3
@jesseleite
This isn’t being used anymore.
483aaa0
@jesseleite
Ensure we bust caches when updating cp nav preferences.
e767756
@jesseleite
Tests wip.
34d8fef
@jesseleite
Cache before applying preference overrides, so that cache is applicab…
2c66d0c 
…le to every user/role/etc.
@jesseleite
Let NavBuilder handle caching.
2e8db19
@jesseleite
Fix edge case isActive bug when moving an item out of a core nav ch…
620f03b 
…ildren closure.
@jesseleite
Merge branch '4.x' of https://github.com/statamic/cms into fix/cp-nav…
e9ec6e0 
…-active-children-part-three
@jesseleite
Be smarter about updating closure based children URL caches when item…
974e843 
… is active.
@jesseleite
Deprecate this, because it’s confusing all around.
4489397
@jesseleite
Add arg to easily remove child CP nav item.
dd00e79
@jesseleite
Test new public find() method as well.
8ef2e15
@jesseleite jesseleite changed the title Fix CP nav item active status regressions [4.x] Fix CP nav item active status regressions Oct 25, 2023
@ryanmitchell ryanmitchell mentioned this pull request Oct 31, 2023
Merged
@jesseleite jesseleite marked this pull request as ready for review November 1, 2023 01:07
@jesseleite jesseleite mentioned this pull request Nov 1, 2023
Merged
@jesseleite jesseleite requested a review from jasonvarga November 1, 2023 14:03
@jesseleite jesseleite marked this pull request as draft November 1, 2023 14:09
@jesseleite
Copy link
Member Author

@jasonvarga This one is draft only because it pulls in #8883 for use in tests. That PR should probably be merged first, then this one can be marked ready 👍

@jesseleite jesseleite marked this pull request as ready for review November 1, 2023 15:46
@jasonvarga jasonvarga merged commit c26ee82 into 4.x Nov 1, 2023
35 checks passed
@jasonvarga jasonvarga deleted the fix/cp-nav-active-children-part-three branch November 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CP Nav: Collections subnav not showing when editing entry
2 participants
@jesseleite @jasonvarga