Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix navigation 'Save Changes' button state #8864

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[4.x] Fix navigation 'Save Changes' button state #8864

merged 1 commit into from
Oct 18, 2023

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue I spotted where the 'Save Changes' button on navigations would take two clicks to clear the browser dirty state and disable the button.

Fixes #8859.

@duncanmcclean duncanmcclean changed the title Fix navigation 'Save Changes' button state [5.x] Fix navigation 'Save Changes' button state Oct 18, 2023
@duncanmcclean duncanmcclean changed the title [5.x] Fix navigation 'Save Changes' button state [4.x] Fix navigation 'Save Changes' button state Oct 18, 2023
@jasonvarga jasonvarga merged commit db28398 into statamic:4.x Oct 18, 2023
17 of 18 checks passed
@duncanmcclean duncanmcclean deleted the fix/navigation-save-changes branch October 20, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving navigations: need to click 'Save Changes' twice for button to be disabled & dirty state to go away
2 participants