[4.x] Remove double-render of fields in Form tag #8861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Forms tag, when
create
is called,getSections
andgetFields
are called to get the sections and fields respectively.However,
getSections
already callsgetFields
. This results ingetFields
being called twice - meaning fields are being rendered twice.This PR changes the behaviour of
create
and runsgetSections
first, as it currently does, and then checks to see if sections were returned - if so, it then extracts the fields from the sections (rather than callinggetFields
again). If there are no sections (i.e. think historical pre-section forms) thengetFields
is explicitly called.