[4.x] Allow keys to be specified on the nocache tag #8858
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for keys on nocache tags...
{{ nocache key="my_key" }}
When used the key wont be randomly generated on each page load, which should go some way to mitigating the memory/views build up thats being reported here: #7039
However if you are using a key it means the contents of the nocache tag can't be session or page load specific, it must be generalised data otherwise data leakage could potentially occur. Maybe its not enough to warn about that and this should be extended to not include session data when keys are specified?