Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Allow keys to be specified on the nocache tag #8858

Closed
wants to merge 1 commit into from

Conversation

ryanmitchell
Copy link
Contributor

This PR adds support for keys on nocache tags...

{{ nocache key="my_key" }}

When used the key wont be randomly generated on each page load, which should go some way to mitigating the memory/views build up thats being reported here: #7039

However if you are using a key it means the contents of the nocache tag can't be session or page load specific, it must be generalised data otherwise data leakage could potentially occur. Maybe its not enough to warn about that and this should be extended to not include session data when keys are specified?

@ryanmitchell ryanmitchell changed the title Allow keys to be specified on the nocache tag [4.x] Allow keys to be specified on the nocache tag Oct 17, 2023
@jasonvarga
Copy link
Member

Thanks. Working on nocache stuff in another PR and I'll see if this will fit in there. Appreciated!

@jasonvarga jasonvarga closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants