[4.x] PHP 8.3 support #8845
Merged
[4.x] PHP 8.3 support #8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
changed the title
|
Can't get it to fail locally like it does in the GitHub tests. 🤷 If anyone has ideas, I'm all ears. |
|
Edit: It's still totally not working. |
jasonvarga
previously approved these changes
Oct 30, 2023
|
Looks like packages weren't being installed correct due to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds PHP 8.3 support.
This also makes sure that any modifications to the
tests.ymlGitHub workflow file trigger the tests to run so #8843 doesn't happen in the future.