Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Console warning generated by invalid tabulator config #8834

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

joseph-d
Copy link
Contributor

@joseph-d joseph-d commented Oct 12, 2023

Using debugbar in Statamic with Antlers profiling enabled currently creates a console warning:

Layout Error - invalid mode set, defaulting to 'fitData' : responsive

This seems to be because layout: 'responsive' isn't a valid option, it's supposed to be responsiveLayout: true as per https://tabulator.info/docs/5.5/layout#responsive

Using debugbar in Statamic with Antlers profiling enabled currently creates a console warning:

```
Layout Error - invalid mode set, defaulting to 'fitData' : responsive
```

This seems to be because 'responsive' isn't a valid option, it's supposed to be `responsiveLayout: true` as per https://tabulator.info/docs/5.5/layout#responsive
@joseph-d joseph-d changed the title Update widget.js Console warning generated by invalid tabulator config Oct 12, 2023
@joseph-d joseph-d changed the title Console warning generated by invalid tabulator config [4.x] Console warning generated by invalid tabulator config Oct 12, 2023
@jasonvarga
Copy link
Member

It's supposed to be "hide", not true. Unless I'm missing something?

CleanShot 2023-10-12 at 12 41 14

@edalzell
Copy link
Contributor

thanks for this, I was trying to figure out where this error was coming from.

@edalzell
Copy link
Contributor

It's supposed to be "hide", not true. Unless I'm missing something?

CleanShot 2023-10-12 at 12 41 14

CleanShot 2023-10-12 at 09 52 53@2x

@edalzell
Copy link
Contributor

interesting, seems a bit conflicting, cuz here's the bit Jason found: https://tabulator.info/docs/5.5/layout#responsive

@jasonvarga
Copy link
Member

Meh, true seems to have the same effect as 'hide'. 🤷

@jasonvarga jasonvarga merged commit 2e5ed24 into statamic:4.x Oct 12, 2023
17 of 19 checks passed
@joseph-d joseph-d deleted the patch-3 branch October 12, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants