[4.x] Makes using the Icon fieldtype with the SVG tag simpler #8815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
deleted the
improve-icon-field-compatibility-with-icon-fieldtype
branch
jasonvarga
restored the
improve-icon-field-compatibility-with-icon-fieldtype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes using the Icon fieldtype with the svg tag simpler.
The first change addresses an issue when using the icon fieldtype with its default configuration. Doing so will use the SVGs within Statamic's
resources/svg/icons/regulardirectory. These are visible within the Control Panel, but since that path was not available within the SVG tag's cascade list, you couldn't actually render them like so:{{ svg src="{field_name | raw}" class="h-4 w-4" /}}The second change drops the requirement for using the
rawmodifier, and allows the SVG tag to be used directly on SVG strings, without requiring the input to be a file reference:{{ svg :src="field_name" class="h-4 w-4" /}}