[4.x] Feature: Add inline label for Toggle when truthy #8814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New computed `inlineLabel` property; used in both the `v-if` and `v-html` value. Falls back to `config.inline_label`, in both `true` and `false` states.
New helper text for `toggle.config.inline_label_when_true`.
New config field to supplement `inline_label`, when value is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
inline_label_when_truefield to the Toggle fieldtype's config, allowing for a separate inline label when the value of the Toggle is truthy. This is non-breaking/backwards compatible, as the existinginline_labelis unchanged and used as the fallback within the Vue component. Here's what this change looks like, in each possible scenario: