[4.x] Clean up Section fieldtype styles #8807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the styles of the
Section
fieldtype, by addressing a few bits that were just slightly off:.rounded
vs.rounded-md
) than the ancestor.card
.top:1px
; replaced with a negativemargin-top
.Those last two were mostly to give a better foundation for addons (eg, Group fieldtype) that use sections to "contain" other fields. But still cleaner to have in core, without adding too much into the stylesheet.
Here's a quick kitchen sink setup, to show the before-and-after. Tweaked a few other things in the code after this was rendered, but the most noticeable changes are shown here:
Lmk if you'd like to see any adjustments, and I'll take a crack at it. Thanks team!