[5.x] Fix CP thumbnail placeholder #11279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the placeholder thumbnail images displayed when an image's dimentions are larger than the configured limits.
The
ThumbnailControllerwas redirecting to a file that doesn't exist in thepublic/vendor/statamic/cpdirectory.This file used to exist when we were using Laravel Mix, but when we switched to Vite in 4.0 (), the
dist.tar.zipfiles we ship with Statamic releases stopped including SVGs.This PR fixes the issue by returning the contents of the SVG directly from our controller, rather than redirecting to another URL.
Fixes #11228.