Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Static warm: recheck whether page is cached for queued requests #11273

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

arthurperton
Copy link
Contributor

@arthurperton arthurperton commented Dec 17, 2024

When using both the --queue and --uncached parameters:

By the time a queued job gets executed, the page was possibly already cached in the meantime. The dedicated StaticWarmUncachedJob checks again if the page is cached, and if so, it won't send the request.

@jasonvarga
Copy link
Member

Weird test failures. I thought it was one of those random failures and rerunning would solve it. 🤔

@arthurperton
Copy link
Contributor Author

I was thinking the same thing. Weird. FWIW I ran the tests locally and they all succeeded.

@jasonvarga
Copy link
Member

I'll check them out. The PR looks good though.

@jasonvarga
Copy link
Member

It's not you. 😄 #11275

@jasonvarga jasonvarga merged commit 1462c27 into statamic:5.x Dec 18, 2024
18 checks passed
@arthurperton arthurperton deleted the pr/static-warm-uncached-job branch December 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants