[5.x] Fix localized error messages on forms when previous URL is incorrect #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great if we could find a way to fix this without needing to add a hidden field. |
|
The only other solution I could think of is the Even though it's not ideal, using a hidden field means that it'll always be the same site as the form was submitted on. |
|
Closing in favour of #11219. |
duncanmcclean
deleted the
fix/localized-error-messages-on-forms-when-images-404
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where form error messages weren't being localized correctly if the user's previous URL was incorrect.
The previous URL could be incorrect if an image referenced on the page 404s, causing a Statamic/Laravel 404 page to be displayed.
Fixes #11179.