Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Filter out empty values in keyed array field #11138

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue with Keyed Array fields, where null values were being saved, instead of being filtered out, like they should be.

Fixes #11074.
Caused by #10467.

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to tests/Fieldtypes/ArrayTest.php

@duncanmcclean
Copy link
Member Author

@jasonvarga Tests added!

@jasonvarga jasonvarga merged commit 099f34f into 5.x Nov 25, 2024
17 checks passed
@jasonvarga jasonvarga deleted the filter-null-values-in-keyed-array branch November 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Globals in an array type(?) are being saved as null from the UI if no value is specified
2 participants