Skip to content

Commit

Permalink
Deprecate this, because it’s confusing all around.
Browse files Browse the repository at this point in the history
  • Loading branch information
jesseleite committed Oct 25, 2023
1 parent 974e843 commit 4489397
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/CP/Navigation/NavItem.php
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,12 @@ public function isChild($isChild = null)
/**
* Active URL pattern to determine when to resolve children for `hasActiveChild()` checks.
*
* Though we still check active patterns for nested URLs internally, having to manually
* use this method should not be needed anymore, not to mention it is confusing for
* addon devs to know when they even need to use it, thus we are deprecating it.
*
* @deprecated
*
* @return $this
*/
public function active($pattern = null)
Expand Down

0 comments on commit 4489397

Please sign in to comment.