-
-
Notifications
You must be signed in to change notification settings - Fork 541
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
ce21344
commit 37c7c2b
Showing
193 changed files
with
20,199 additions
and
4,350 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
37c7c2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jasonvarga I checked for some changes you made. As an exemple, Currencies. ZMK is not available nowadays ans has been replaced by ZMW since 2013/01/01. The currency code for Liberia Dollar is LRD, and the currency symbol is $. And so on.
Therefore my version was good, certainly a little bit more complete than the one you found and used for the currencies dictionnary included in Statamic.
I understand you want to sort the currencies but as a user I rather prefer the currencies to be sorted by name than by code (nobody is going to fetch a code, isn't he?)
As for the countries, the sort order cannot be the same in English or in another language (you still want a sort order by name rather than by code as a user).
Or could you add a default sort setting somewhere?
Let me know. Take care!
37c7c2b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
php translate generate
command automates the sorting. I just let it do it. It will keep everything consistent.As for the changes to the currencies - if they are out of date, the dictionary code will need to be adjusted. The translations are just translations.