Feature/ab#978 create helm chart #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flonix8
reviewed
Dec 19, 2023
There was a problem hiding this comment.
I would suggest using StatefulSet instead of Deployment, because this is also a component that we rather do not want to run multiple times in parallel...
| value: /{{ include "databackend.fullname" . }} | ||
| - name: SPRING_SECURITY_OAUTH2_CLIENT_REGISTRATION_GITHUB_CLIENTID | ||
| value: {{ .Values.app.context_path | quote }} | ||
| {{- if .Values.auth.enabled }} |
There was a problem hiding this comment.
I have not tried it, but I would expect that we'd need to also set SPRING_PROFILES_ACTIVE=dev if we want to start without authentication.
There was a problem hiding this comment.
no auth in code yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on Helm chart to make DataBackend deployable to Kubernetes.
Description
This is a first working verison for a Helm chart.
Motivation and Context
App needs to be deployable
How has this been tested?
Deployment to test clusters
Screenshots (if appropriate):
Types of changes
Checklist: