Feature/ab#1319 add detail panel to each marker on map #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 17, 2024 18:13
… filter + removed scrollbar + fixed translation mistake
witchpou
changed the base branch from
main
to
feature/AB#1320-FILTER-BY-INCIDENT-TYPE
witchpou
requested changes
Dec 19, 2024
There was a problem hiding this comment.
- Please fix issues in PR Added a feature to filter incidents by type #139 in the according PR. Answer questions.
- Dialog is looking different and not user friendly. Why you copied the code? Maintenance and further extensions might be difficult.
witchpou
reviewed
Dec 19, 2024
| right: showPanel ? '320px' : '10px', | ||
| bgcolor: 'white' | ||
|
|
||
| function DecisionDialog() { |
There was a problem hiding this comment.
What was the reason to place the implementation of the DecisionDialog Component inside the file for the DecisionOverviewMap? Think about implementation options which would provide a better maintenance.
witchpou
requested changes
Jan 14, 2025
witchpou
changed the base branch from
feature/AB#1320-FILTER-BY-INCIDENT-TYPE
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: