Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create sample data sets for conversion verification #34

Open
starturtle opened this issue Oct 30, 2020 · 1 comment
Open

Create sample data sets for conversion verification #34

starturtle opened this issue Oct 30, 2020 · 1 comment
Assignees
@starturtle
Labels
enhancement New feature or request investigation Something has high impact on future design and needs to be chosen carefully refactoring Stuff that needs reworking to be less cumbersome to use, less error-prone, or easier to read.
Milestone
Test Functionality

Comments

@starturtle
Copy link
Owner

Currently, only using the program and asking oneself whether the result looks good is available to test the algorithm overall.

There should be input/desired output pairs available for testing.

Most likely, this will spawn rethinking of the distance algorithm.
@starturtle starturtle added enhancement New feature or request investigation Something has high impact on future design and needs to be chosen carefully refactoring Stuff that needs reworking to be less cumbersome to use, less error-prone, or easier to read. labels Oct 30, 2020
@starturtle starturtle added this to the Test Functionality milestone Oct 30, 2020
@starturtle starturtle mentioned this issue Oct 30, 2020
Merged
@starturtle
Copy link
Owner Author

Output currently doesn't look good. What if it makes sense to also provide/suggest some prep work?
Regardless, Some of the color selections really spawn the question what colors should be seen alike.

@starturtle starturtle mentioned this issue Oct 31, 2020
Open
@starturtle starturtle self-assigned this Nov 5, 2020
starturtle added a commit that referenced this issue Nov 5, 2020
@starturtle
#34 removed image resources from qrc as they get copied so there's a …
de5f5c4 
…local file path to load them from, extended tests for SourceImage further (now has an off-by-two on the image dimensions, but at least doesn't crash with div/0 on the unit test...)
starturtle added a commit that referenced this issue Nov 6, 2020
@starturtle
#34 fixed expectations for subrect scaling
061fe26
starturtle added a commit that referenced this issue Nov 6, 2020
@starturtle
#34 added ASCII art based image comparison of cropped image data. Ima…
d31e3fd 
…ges are considered matching when there's less than 2% of image pixels that differ by less than 0x20 across each channel. Note that this is really optimistic when talking images with a lot of edges, as those are subject to very slight scaling artefacts, and the two images compared are created by two different algorithms.
starturtle added a commit that referenced this issue Nov 6, 2020
@starturtle
#34 store image clippings to build folder during tests (for later exa…
3f55aa4 
…mination and manual comparison).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starturtle starturtle

Labels
enhancement New feature or request investigation Something has high impact on future design and needs to be chosen carefully refactoring Stuff that needs reworking to be less cumbersome to use, less error-prone, or easier to read.
Projects
None yet
Milestone
Test Functionality
Development

No branches or pull requests
1 participant
@starturtle