13 refactor logging #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GCD calculus, and that if the DOCTEST_INCLUDE_DIR is not set (or BUILD_TESTING is switched off), test projects are not being configured and thus, doctest is not needed.
…for data types and log level triggers
…o conflicts between doctest and the enum value names, two needed renaming to be unit-testable...
starturtle
commented
Oct 29, 2020
… log stream, fixed test building config, added more usage/installation documentation, reduced linked Qt packages for tests, added documentational comments, ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13
changed syntax so the LogStream class is not actually a stream, but uses operator<< to log.
momentary log levels switch logging on and off and serve as a stand-in for line breaks.
added a unit test that will verify that the right log level combinations cause the right reaction (maybe that one should get explicitly written down for clarity, though...)
closes #31
DOCTEST_INCLUDE_DIR is being evaluated now. if it is empty, BUILD_TESTING won't be set, also, BUILD_TESTING can be configured to be OFF. If it is, the test code is not included anywhere, and the test project configs are not generated.