Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change (docker): Combine nginx and php to a single image for both ASP and bf2sclone with env var support for configuration #133

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Change (docker): Combine nginx and php to a single image for both ASP and bf2sclone with env var support for configuration #133

merged 1 commit into from
Nov 22, 2023

Conversation

leojonathanoh
Copy link
Member

@leojonathanoh leojonathanoh commented Nov 2, 2023 •
edited
Loading

Previous: In <= v2.5.x, asp and bf2sclone each had separate nginx and php images.

Now: Single asp and bf2sclone images containing both nginx and php, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

  • Easier to deploy / upgrade. No need to separate asp-nginx and asp-php containers
  • Environment variable configuration means no more need to mount config.php into asp and bf2sclone containers
  • Entrypoint script sets permissions on volumes. init-container should only need to set permissions for db volume.

Notable changes:

  • Add documentation for upgrading docker images to v2.6.x from prior versions
  • Update ./docs/examples
  • Add tests for production builds for examples in ./docs/examples

Closes #132

@leojonathanoh leojonathanoh self-assigned this Nov 2, 2023
@leojonathanoh leojonathanoh added this to the 2.6.0 milestone Nov 2, 2023
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch from e3f7586 to a907703 Compare November 2, 2023 18:44
@leojonathanoh leojonathanoh changed the title Change (docker): Combine nginx and php to a single image for both ASP and bf2sclone with env var support for configuration Fix int test 1 Nov 2, 2023
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch from 1289458 to f7622f8 Compare November 2, 2023 18:46
@leojonathanoh leojonathanoh changed the title Fix int test 1 Change (docker): Combine nginx and php to a single image for both ASP and bf2sclone with env var support for configuration Nov 2, 2023
@leojonathanoh leojonathanoh removed the fix label Nov 2, 2023
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch 14 times, most recently from 456f312 to 74d03b3 Compare November 9, 2023 18:26
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch 7 times, most recently from f637928 to 049f790 Compare November 10, 2023 23:50
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch from 65dfcfc to fe94cf4 Compare November 22, 2023 02:01
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch from 9381546 to f6a193f Compare November 22, 2023 02:17
@leojonathanoh
Change (docker): Combine nginx and php to a single image for both `AS…
5345d95 
…P` and `bf2sclone` with env var support for configuration

Previous: In <= v2.5.x, `asp` and `bf2sclone` each had separate `nginx` and `php` images.

Now: Single `asp` and `bf2sclone` images containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:
- Easier to deploy / upgrade. No need to separate `asp-nginx` and `asp-php` containers
- Environment variable configuration means no more need to mount `config.php` into `asp` and `bf2sclone` containers
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume.

Notable changes:
- Add documentation for upgrading docker images to v2.6.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #132
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch from f6a193f to 5345d95 Compare November 22, 2023 02:36
@leojonathanoh leojonathanoh merged commit 74d69f4 into master Nov 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leojonathanoh leojonathanoh

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Single image containing nginx and php (for both ASP and bf2sclone)
1 participant
@leojonathanoh