Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked batch inverse #983

Merged
merged 1 commit into from
Jan 14, 2025
Merged

chunked batch inverse #983

merged 1 commit into from
Jan 14, 2025

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

ohad-starkware commented Jan 13, 2025

This was referenced Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (aa3c697) to head (8e3237b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #983   +/-   ##
=======================================
  Coverage   92.32%   92.33%           
=======================================
  Files         105      105           
  Lines       14234    14252   +18     
  Branches    14234    14252   +18     
=======================================
+ Hits        13142    13160   +18     
  Misses       1018     1018           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohad-starkware ohad-starkware force-pushed the ohad/allocating_batch_inverse branch from 47ddd44 to 9633c54 Compare January 13, 2025 13:35
@ohad-starkware ohad-starkware force-pushed the ohad/chunked_batch_inverse branch from 2672ea4 to e304b42 Compare January 13, 2025 13:35
@ohad-starkware ohad-starkware self-assigned this Jan 13, 2025
@ohad-starkware ohad-starkware force-pushed the ohad/allocating_batch_inverse branch 2 times, most recently from 8aee306 to 7bc346b Compare January 14, 2025 08:31
@ohad-starkware ohad-starkware force-pushed the ohad/chunked_batch_inverse branch 2 times, most recently from 110b581 to 48e6c9d Compare January 14, 2025 11:33
@ohad-starkware ohad-starkware force-pushed the ohad/allocating_batch_inverse branch 2 times, most recently from 3ae5d1d to b0d17cb Compare January 14, 2025 14:09
@ohad-starkware ohad-starkware force-pushed the ohad/chunked_batch_inverse branch from 48e6c9d to aa8bc17 Compare January 14, 2025 14:09
@ohad-starkware ohad-starkware changed the base branch from ohad/allocating_batch_inverse to graphite-base/983 January 14, 2025 14:50
@ohad-starkware ohad-starkware force-pushed the ohad/chunked_batch_inverse branch from aa8bc17 to 2c61a02 Compare January 14, 2025 14:50
@ohad-starkware ohad-starkware changed the base branch from graphite-base/983 to dev January 14, 2025 14:51
@ohad-starkware ohad-starkware force-pushed the ohad/chunked_batch_inverse branch from 2c61a02 to 11011c8 Compare January 14, 2025 14:51
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware changed the base branch from dev to graphite-base/983 January 14, 2025 16:05
@ohad-starkware ohad-starkware force-pushed the ohad/chunked_batch_inverse branch from 11011c8 to 2e2ddba Compare January 14, 2025 16:05
Copy link
Collaborator Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware force-pushed the ohad/chunked_batch_inverse branch from 2e2ddba to 8e3237b Compare January 14, 2025 16:13
@ohad-starkware ohad-starkware changed the base branch from graphite-base/983 to dev January 14, 2025 16:13
@ohad-starkware ohad-starkware merged commit 1dff27d into dev Jan 14, 2025
29 of 33 checks passed
Copy link
Collaborator Author

Merge activity

  • Jan 14, 11:17 AM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants