Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PreProcessedColumn Enum #968

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove PreProcessedColumn Enum #968

merged 1 commit into from
Jan 14, 2025
+2 −126

Conversation

Gali-StarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review January 8, 2025 09:44
This was referenced Jan 8, 2025
Merged
Closed
Merged
@Gali-StarkWare Graphite App
Copy link
Contributor Author

Gali-StarkWare commented Jan 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from f5399f2 to 008ed91 Compare January 8, 2025 09:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (71516ef) to head (8be88da).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #968      +/-   ##
==========================================
+ Coverage   91.91%   92.37%   +0.45%     
==========================================
  Files         105      105              
  Lines       14289    14218      -71     
  Branches    14289    14218      -71     
==========================================
  Hits        13134    13134              
+ Misses       1081     1010      -71     
  Partials       74       74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ohad-starkware
ohad-starkware approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 8d41b00 to 6c4e2e3 Compare January 9, 2025 13:40
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 008ed91 to f791b51 Compare January 9, 2025 13:40
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 6c4e2e3 to 05e2eb6 Compare January 9, 2025 14:28
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from f791b51 to 479f469 Compare January 9, 2025 14:28
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 05e2eb6 to 64c2554 Compare January 9, 2025 14:48
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 479f469 to e127683 Compare January 9, 2025 14:48
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 64c2554 to e28c6ce Compare January 12, 2025 08:53
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from e127683 to e7785d9 Compare January 12, 2025 08:53
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from e28c6ce to 9f04a50 Compare January 12, 2025 08:55
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from e7785d9 to 9a4841e Compare January 12, 2025 08:55
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 9f04a50 to e43b9e4 Compare January 12, 2025 09:18
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 9a4841e to 2d12f58 Compare January 12, 2025 09:18
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from e43b9e4 to 94c4e99 Compare January 12, 2025 10:06
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 2d12f58 to eacecc0 Compare January 12, 2025 10:06
ohad-starkware
ohad-starkware approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 9b3cf14 to 672045e Compare January 13, 2025 08:21
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 94c4e99 to f7f8bb4 Compare January 13, 2025 08:50
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 672045e to 6c2570f Compare January 13, 2025 08:50
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from f7f8bb4 to e226556 Compare January 13, 2025 09:00
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 6c2570f to 99ebe6f Compare January 13, 2025 09:00
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 99ebe6f to 3e1ebbc Compare January 13, 2025 09:44
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from e226556 to 8620884 Compare January 13, 2025 13:43
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 3e1ebbc to eb75d21 Compare January 13, 2025 13:43
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 8620884 to bf8c714 Compare January 13, 2025 13:54
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from eb75d21 to 9f2fde6 Compare January 13, 2025 13:54
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from bf8c714 to b0724fb Compare January 13, 2025 14:46
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 9f2fde6 to 8cb5c0e Compare January 13, 2025 14:46
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from b0724fb to 1cf776b Compare January 13, 2025 14:55
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 8cb5c0e to d4c77d6 Compare January 13, 2025 14:56
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 1cf776b to 792011f Compare January 14, 2025 08:04
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from d4c77d6 to 1684ae6 Compare January 14, 2025 08:04
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 792011f to 026d394 Compare January 14, 2025 08:08
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 1684ae6 to bfdd96e Compare January 14, 2025 08:08
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 026d394 to 2a57127 Compare January 14, 2025 08:41
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from bfdd96e to bfd3035 Compare January 14, 2025 08:41
@Gali-StarkWare Gali-StarkWare force-pushed the gali/use_preprocessed_column_trait branch from 2a57127 to e9069a2 Compare January 14, 2025 10:51
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from bfd3035 to 21c9f4f Compare January 14, 2025 10:51
@Gali-StarkWare Gali-StarkWare mentioned this pull request Jan 14, 2025
Merged
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/use_preprocessed_column_trait to graphite-base/968 January 14, 2025 11:15
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 21c9f4f to cabb311 Compare January 14, 2025 11:18
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/968 to dev January 14, 2025 11:19
@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from cabb311 to 8be88da Compare January 14, 2025 11:19
shaharsamocha7
shaharsamocha7 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@Gali-StarkWare Gali-StarkWare force-pushed the gali/remove_preprocessed_column_enum branch from 8be88da to 7e6c81d Compare January 14, 2025 13:05
@Gali-StarkWare Graphite App
Copy link
Contributor Author

Gali-StarkWare commented Jan 14, 2025 •
edited
Loading

Merge activity

  • Jan 14, 9:01 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 14, 9:01 AM EST: A user merged this pull request with Graphite.

@Gali-StarkWare Gali-StarkWare merged commit cfb5031 into dev Jan 14, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharsamocha7 shaharsamocha7 shaharsamocha7 approved these changes

@ohad-starkware ohad-starkware Awaiting requested review from ohad-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gali-StarkWare @reviewable-StarkWare @codecov-commenter @shaharsamocha7 @ohad-starkware