Formal preprocessed columns in expressions. #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #923 +/- ##
==========================================
- Coverage 91.43% 91.42% -0.01%
==========================================
Files 94 94
Lines 13686 13695 +9
Branches 13686 13695 +9
==========================================
+ Hits 12514 12521 +7
- Misses 1057 1059 +2
Partials 115 115 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 53e8a1a | Previous: cd8b37b | Ratio |
|---|---|---|---|
merkle throughput/simd merkle |
29588458 ns/iter (± 261863) |
13712527 ns/iter (± 579195) |
2.16 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
Merged
andrewmilson
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.