Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for expression simplifier. #908

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Added test for expression simplifier. #908

merged 1 commit into from
Dec 2, 2024

Conversation

Alon-Ti
Copy link
Contributor

@Alon-Ti Alon-Ti commented Nov 27, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Alon-Ti Alon-Ti mentioned this pull request Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (4af2d44) to head (f4565e3).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #908      +/-   ##
==========================================
+ Coverage   91.51%   91.55%   +0.04%     
==========================================
  Files          93       93              
  Lines       13375    13429      +54     
  Branches    13375    13429      +54     
==========================================
+ Hits        12240    12295      +55     
+ Misses       1021     1020       -1     
  Partials      114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alon-Ti Alon-Ti marked this pull request as ready for review November 27, 2024 14:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 7414829 Previous: cd8b37b Ratio
iffts/simd ifft/22 12685608 ns/iter (± 145825) 6306399 ns/iter (± 210024) 2.01
merkle throughput/simd merkle 29183557 ns/iter (± 525268) 13712527 ns/iter (± 579195) 2.13

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

@Alon-Ti Alon-Ti force-pushed the alont/simplify-test branch from e5927ae to 63f1627 Compare December 1, 2024 14:51
@Alon-Ti Alon-Ti changed the base branch from alont/eval-expr to graphite-base/908 December 1, 2024 15:37
@Alon-Ti Alon-Ti force-pushed the alont/simplify-test branch from 63f1627 to 8dbd090 Compare December 1, 2024 15:37
@Alon-Ti Alon-Ti changed the base branch from graphite-base/908 to dev December 1, 2024 15:38
@Alon-Ti Alon-Ti force-pushed the alont/simplify-test branch from 8dbd090 to f4565e3 Compare December 1, 2024 15:38
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

@Alon-Ti Alon-Ti merged commit a459c48 into dev Dec 2, 2024
17 of 19 checks passed
Copy link
Contributor Author

Alon-Ti commented Dec 2, 2024

Merge activity

  • Dec 2, 3:12 AM EST: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants