type conversion (#880) #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #900 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 93 93
Lines 13339 13339
Branches 13339 13339
=======================================
Hits 12250 12250
Misses 972 972
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Alon-Ti
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
ohad-starkware
force-pushed
the
ohad/export_relation
branch
from
21af0b4 to
740381c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 740381c | Previous: cd8b37b | Ratio |
|---|---|---|---|
iffts/simd ifft/22 |
12614998 ns/iter (± 151548) |
6306399 ns/iter (± 210024) |
2.00 |
merkle throughput/simd merkle |
28088905 ns/iter (± 474061) |
13712527 ns/iter (± 579195) |
2.05 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type conversion (#880)
Co-Authored-By: ilyalesokhin-starkware [email protected]
Rename Constant trace -> Preprocessed trace. (#881)
Remove unused mutability. (#885)
Added LogupAtRow functionality to EvalAtRow. (#875)
Avoid filtering out unused columns. (#886)
The prover does not filter them out.
Abstracted
eval.write_fracs toeval.add_to_relations. (#876)Initialize logups automatically when first used. (#879)
Formal Expr logup variables. (#887)
Expr formatting. (#888)
State machine constraint string. (#889)
Separated Xor table types. (#883)
Remove redundant
collectin framework. (#896)Add arithmetic op counts to InfoEvaluator (#832)
Make CommitmentSchemeProver::prove_values take ownership (#852)
Add gen_preprocessed_columns. (#891)
Added total_ and claimed_sums as formal variables in ExprEvaluator. (#892)
SIMD backend for poseidon252 merkle ops - CPU IMPL