Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain #898

Closed
wants to merge 1 commit into from
Closed

Conversation

shaharsamocha7
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 94.32624% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.40%. Comparing base (8550b7d) to head (48a733f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
crates/prover/src/core/backend/simd/utils.rs 66.66% 7 Missing ⚠️
crates/prover/src/core/pcs/verifier.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #898      +/-   ##
==========================================
+ Coverage   91.48%   92.40%   +0.92%     
==========================================
  Files          98       97       -1     
  Lines       13733    13259     -474     
  Branches    13733    13259     -474     
==========================================
- Hits        12563    12252     -311     
+ Misses       1055      934     -121     
+ Partials      115       73      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weikengchen
Copy link
Contributor

This PR would be useful in that a few Rust development tools start to be no longer compatible with the 1.77-nightly version that was being used.

@shaharsamocha7 shaharsamocha7 force-pushed the shahars/update_toolchain_test branch from 13209cc to 48a733f Compare December 17, 2024 08:53
Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres a more recent toolchain btw
:lgtm:

Reviewed 3 of 59 files at r1, 2 of 36 files at r2, all commit messages.
Reviewable status: 5 of 61 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants