Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor constraint evaluation. #696

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jul 3, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (4fe7142) to head (aecb53f).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #696      +/-   ##
==========================================
+ Coverage   90.66%   90.67%   +0.01%     
==========================================
  Files          76       76              
  Lines       10103    10117      +14     
  Branches    10103    10117      +14     
==========================================
+ Hits         9160     9174      +14     
  Misses        861      861              
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 06-26-implement_from_qm31_array_for_qm31 branch from 32defad to 1665b10 Compare July 8, 2024 07:32
@alonh5 alonh5 force-pushed the 07-03-refactor_constraint_evaluation branch from 7f1a422 to 04cd0bb Compare July 8, 2024 07:32
@alonh5 alonh5 force-pushed the 06-26-implement_from_qm31_array_for_qm31 branch from 1665b10 to 1d1b46c Compare July 8, 2024 08:07
@alonh5 alonh5 force-pushed the 07-03-refactor_constraint_evaluation branch from 04cd0bb to 257a0bc Compare July 8, 2024 08:07
@alonh5 alonh5 force-pushed the 06-26-implement_from_qm31_array_for_qm31 branch from 1d1b46c to 5c8c89d Compare July 8, 2024 08:44
@alonh5 alonh5 force-pushed the 07-03-refactor_constraint_evaluation branch from 257a0bc to 89263ab Compare July 8, 2024 10:30
@alonh5 alonh5 changed the base branch from 06-26-implement_from_qm31_array_for_qm31 to dev July 8, 2024 10:30
@alonh5 alonh5 force-pushed the 07-03-refactor_constraint_evaluation branch from 89263ab to 2fd19a5 Compare July 8, 2024 11:39
@alonh5 alonh5 force-pushed the 07-03-refactor_constraint_evaluation branch from 2fd19a5 to aecb53f Compare July 9, 2024 10:31
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit defcfe2 into dev Jul 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants