Remove interaction_elements_ids from Component trait.

starkware-libs · Jul 8, 2024 · c20e41a · c20e41a
1 parent a9bb818
commit c20e41a
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 28 deletions.
diff --git a/crates/prover/src/core/air/mod.rs b/crates/prover/src/core/air/mod.rs
@@ -49,9 +49,6 @@ pub trait Component {
         point: CirclePoint<SecureField>,
     ) -> TreeVec<ColumnVec<Vec<CirclePoint<SecureField>>>>;
 
-    /// Returns the ids of the interaction elements used by the component.
-    fn interaction_element_ids(&self) -> Vec<String>;
-
     /// Evaluates the constraint quotients combination of the component at a point.
     fn evaluate_constraint_quotients_at_point(
         &self,

diff --git a/crates/prover/src/core/prover/mod.rs b/crates/prover/src/core/prover/mod.rs
@@ -438,10 +438,6 @@ mod tests {
             TreeVec::new(vec![vec![vec![point]]])
         }
 
-        fn interaction_element_ids(&self) -> Vec<String> {
-            vec![]
-        }
-
         fn evaluate_constraint_quotients_at_point(
             &self,
             _point: CirclePoint<SecureField>,

diff --git a/crates/prover/src/examples/fibonacci/component.rs b/crates/prover/src/examples/fibonacci/component.rs
@@ -104,10 +104,6 @@ impl Component for FibonacciComponent {
         )])
     }
 
-    fn interaction_element_ids(&self) -> Vec<String> {
-        vec![]
-    }
-
     fn evaluate_constraint_quotients_at_point(
         &self,
         point: CirclePoint<SecureField>,

diff --git a/crates/prover/src/examples/poseidon/mod.rs b/crates/prover/src/examples/poseidon/mod.rs
@@ -118,10 +118,6 @@ impl Component for PoseidonComponent {
         )])
     }
 
-    fn interaction_element_ids(&self) -> Vec<String> {
-        vec![]
-    }
-
     fn evaluate_constraint_quotients_at_point(
         &self,
         point: CirclePoint<SecureField>,

diff --git a/crates/prover/src/examples/wide_fibonacci/component.rs b/crates/prover/src/examples/wide_fibonacci/component.rs
@@ -55,6 +55,10 @@ impl WideFibComponent {
         N_COLUMNS
     }
 
+    pub fn interaction_element_ids(&self) -> Vec<String> {
+        vec![ALPHA_ID.to_string(), Z_ID.to_string()]
+    }
+
     fn evaluate_trace_boundary_constraints_at_point(
         &self,
         point: CirclePoint<SecureField>,
@@ -211,10 +215,6 @@ impl Component for WideFibComponent {
         ])
     }
 
-    fn interaction_element_ids(&self) -> Vec<String> {
-        vec![ALPHA_ID.to_string(), Z_ID.to_string()]
-    }
-
     fn evaluate_constraint_quotients_at_point(
         &self,
         point: CirclePoint<SecureField>,

diff --git a/crates/prover/src/examples/wide_fibonacci/simd.rs b/crates/prover/src/examples/wide_fibonacci/simd.rs
@@ -22,7 +22,7 @@ use crate::core::poly::circle::{CanonicCoset, CircleEvaluation};
 use crate::core::poly::BitReversedOrder;
 use crate::core::prover::BASE_TRACE;
 use crate::core::{ColumnVec, InteractionElements, LookupValues};
-use crate::examples::wide_fibonacci::component::{ALPHA_ID, N_COLUMNS, Z_ID};
+use crate::examples::wide_fibonacci::component::N_COLUMNS;
 use crate::trace_generation::registry::ComponentGenerationRegistry;
 use crate::trace_generation::{AirTraceGenerator, AirTraceVerifier, ComponentTraceGenerator};
 
@@ -112,10 +112,6 @@ impl Component for SimdWideFibComponent {
         )])
     }
 
-    fn interaction_element_ids(&self) -> Vec<String> {
-        vec![ALPHA_ID.to_string(), Z_ID.to_string()]
-    }
-
     fn evaluate_constraint_quotients_at_point(
         &self,
         point: CirclePoint<SecureField>,

diff --git a/crates/prover/src/trace_generation/registry.rs b/crates/prover/src/trace_generation/registry.rs
@@ -75,10 +75,6 @@ mod tests {
             todo!()
         }
 
-        fn interaction_element_ids(&self) -> Vec<String> {
-            todo!()
-        }
-
         fn evaluate_constraint_quotients_at_point(
             &self,
             _point: CirclePoint<SecureField>,
-Original file line number
+Diff line change
@@ Expand Up / @@ -104,10 +104,6 @@ impl Component for FibonacciComponent { @@
             )])
         }
-        fn interaction_element_ids(&self) -> Vec<String> {
-            vec![]
-        }
         fn evaluate_constraint_quotients_at_point(
             &self,
             point: CirclePoint<SecureField>,
@@ Expand Down @@