chore(blockifier): have limit_steps_by_resources flag rep charge_fee flag and enforce_fee ret val

[avivg-starkware]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.63%. Comparing base (b0cfe82) to head (3c6fe63).
Report is 415 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (3c6fe63). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (3c6fe63)
	3	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #833       +/-   ##
===========================================
- Coverage   74.18%   63.63%   -10.56%     
===========================================
  Files         359      131      -228     
  Lines       36240    17487    -18753     
  Branches    36240    17487    -18753     
===========================================
- Hits        26886    11128    -15758     
+ Misses       7220     5572     -1648     
+ Partials     2134      787     -1347     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.310 ms 66.396 ms 66.493 ms]
change: [-2.9615% -1.9610% -1.0823%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[meship-starkware]

Reviewed 1 of 2 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)

---

crates/blockifier/src/blockifier/stateful_validator.rs line 118 at r2 (raw file):

        let tx_context = Arc::new(self.tx_executor.block_context.to_tx_context(tx));

        let limit_steps_by_resources =  tx.create_tx_info().enforce_fee(); //aviv: was true;

Remove all aviv comments.

---

crates/blockifier/src/concurrency/worker_logic.rs line 30 at r2 (raw file):

    TransactionInfoCreator,
};

Revert this change.

[meship-starkware]

Reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

[meship-starkware]

Reviewed 11 of 14 files at r4, all commit messages.
Reviewable status: 11 of 14 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

[meship-starkware]

Reviewed 3 of 14 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[meship-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/get_execution_info.rs line 244 at r4 (raw file):

        ..trivial_external_entry_point_with_address(test_contract_address)
    };

Revert this space

[avivg-starkware]

Reviewable status: 10 of 16 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @noaov1)

---

crates/blockifier/src/transaction/transaction_execution.rs line 144 at r7 (raw file):

Previously, noaov1 (Noa Oved) wrote…

We can leave it as is. However, we need to add a special treatment for the L1 handler case.

Done.

[meship-starkware]

Reviewed 6 of 6 files at r13, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @noaov1)

a discussion (no related file):
Please rebase over main

---

[meship-starkware]

Reviewed 12 of 12 files at r15, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1)

[noaov1]

Reviewed 1 of 6 files at r13, 1 of 12 files at r15, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[noaov1]

Reviewed 1 of 9 files at r10, 4 of 6 files at r13, 9 of 12 files at r15, 3 of 3 files at r16, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[noaov1]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/transaction/transaction_execution.rs line 144 at r7 (raw file):

Previously, avivg-starkware wrote…

Done.

Changed my mind- please set it to false.

[noaov1]

Reviewed 1 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

[avivg-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

---

crates/blockifier/src/transaction/transaction_execution.rs line 144 at r7 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Changed my mind- please set it to false.

Done.

[avivg-starkware]

Reviewed 1 of 14 files at r4, 1 of 9 files at r9, 1 of 9 files at r10, 2 of 7 files at r12, 4 of 6 files at r13, 10 of 12 files at r15, 3 of 3 files at r16.
Reviewable status: 13 of 22 files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @noaov1)

[noaov1]

Reviewed 9 of 9 files at r17, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avivg-starkware)

---

crates/blockifier/src/test_utils/struct_impls.rs line 89 at r17 (raw file):

        self.execute_directly_given_tx_info(
            state,
            TransactionInfo::Deprecated(DeprecatedTransactionInfo::default()),

?

Suggestion:

             // TODO(Yoni, 1/12/2024): change the default to V3.
            TransactionInfo::Deprecated(DeprecatedTransactionInfo::default()),

[avivg-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

---

crates/blockifier/src/test_utils/struct_impls.rs line 89 at r17 (raw file):

Previously, noaov1 (Noa Oved) wrote…

?

there's only one comment such as this I see in this file on origin/main ( line 54 ). perhaps it was recently changed?

[avivg-starkware]

Reviewed 9 of 9 files at r17.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

[noaov1]

Reviewed 3 of 3 files at r18, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)

[avivg-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware)