Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fee): implement methods on resource bounds #703

Closed
wants to merge 1 commit into from

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Sep 4, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 62.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 75.81%. Comparing base (8ed7773) to head (b747ef9).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/transaction/objects.rs 44.64% 31 Missing ⚠️
crates/starknet_api/src/transaction.rs 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   76.55%   75.81%   -0.74%     
==========================================
  Files         351       85     -266     
  Lines       37088    10988   -26100     
  Branches    37088    10988   -26100     
==========================================
- Hits        28393     8331   -20062     
+ Misses       6380     2223    -4157     
+ Partials     2315      434    -1881     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant