chore: update resources for OS with revert log #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyalesokhin-starkware
force-pushed
the
ilya/resources
branch
from
be5c52e to
43ff7ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
- Coverage 76.55% 76.51% -0.05%
==========================================
Files 351 351
Lines 37088 37161 +73
Branches 37088 37161 +73
==========================================
+ Hits 28393 28432 +39
- Misses 6380 6413 +33
- Partials 2315 2316 +1 ☔ View full report in Codecov by Sentry. |
Yoni-Starkware
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Oh, I think that @AvivYossef-starkware updated this file first. So need to wait for his code to enter dev. Blocking for now.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
ilyalesokhin-starkware
force-pushed
the
ilya/resources
branch
3 times, most recently
from
d52c0c5 to
17264b1
Compare
ilyalesokhin-starkware
force-pushed
the
ilya/resources
branch
4 times, most recently
from
78a3372 to
d039b10
Compare
ilyalesokhin-starkware
force-pushed
the
ilya/resources
branch
from
d039b10 to
af7290f
Compare
Yoni-Starkware
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, 3 of 3 files at r5, 3 of 3 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is