Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main-v0.13.2 into main #691

Closed

Conversation

meship-starkware
Copy link
Contributor

@meship-starkware meship-starkware commented Sep 3, 2024

This change is Reviewable

@meship-starkware
Copy link
Contributor Author

Src Dst .github/workflows/main.yml

Copy link
Contributor Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r2, 2 of 3 files at r3, 9 of 9 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (9260e52) to head (81f0f8c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   75.84%   71.00%   -4.84%     
==========================================
  Files         352       85     -267     
  Lines       37448    10964   -26484     
  Branches    37448    10964   -26484     
==========================================
- Hits        28401     7785   -20616     
+ Misses       6726     2791    -3935     
+ Partials     2321      388    -1933     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r7, 1 of 4 files at r8.
Reviewable status: 12 of 15 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


.github/workflows/main.yml line 88 at r7 (raw file):

    steps:
      - uses: actions/checkout@v4
=======

@dorimedini-starkware can you PTAL?

Code quote:

      - run: scripts/clippy.sh

  doc:
    runs-on: starkware-ubuntu-latest-small
    env:
      RUSTDOCFLAGS: "-D warnings"
    steps:
      - uses: actions/checkout@v4
||||||| e9fef0f80
      - run: scripts/clippy.sh

  doc:
    runs-on: starkware-ubuntu-latest-small
    # env:
    #   RUSTDOCFLAGS: "-D warnings"
    steps:
      - uses: actions/checkout@v4
=======

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r2, 3 of 4 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware force-pushed the meshi/merge-main-v0.13.2-into-main-1725348388 branch from 60c2321 to 81f0f8c Compare September 5, 2024 06:12
@meship-starkware meship-starkware deleted the meshi/merge-main-v0.13.2-into-main-1725348388 branch September 5, 2024 06:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants