-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main-v0.13.2 into main #691
Merge main-v0.13.2 into main #691
Conversation
* chore(blockifier): add with_attr error message * chore(blockifier): add with_attr error message to fail test
chore(blockifier): fix code gas cost
Signed-off-by: Dori Medini <[email protected]>
This reverts commit 78ceca6.
chore(blockifier): temporarily revert version changes for publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r2, 2 of 3 files at r3, 9 of 9 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
- Coverage 75.84% 71.00% -4.84%
==========================================
Files 352 85 -267
Lines 37448 10964 -26484
Branches 37448 10964 -26484
==========================================
- Hits 28401 7785 -20616
+ Misses 6726 2791 -3935
+ Partials 2321 388 -1933 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 9 files at r7, 1 of 4 files at r8.
Reviewable status: 12 of 15 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
.github/workflows/main.yml
line 88 at r7 (raw file):
steps: - uses: actions/checkout@v4 =======
@dorimedini-starkware can you PTAL?
Code quote:
- run: scripts/clippy.sh
doc:
runs-on: starkware-ubuntu-latest-small
env:
RUSTDOCFLAGS: "-D warnings"
steps:
- uses: actions/checkout@v4
||||||| e9fef0f80
- run: scripts/clippy.sh
doc:
runs-on: starkware-ubuntu-latest-small
# env:
# RUSTDOCFLAGS: "-D warnings"
steps:
- uses: actions/checkout@v4
=======
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r2, 3 of 4 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
…3.2-into-main-1725348388
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
…3.2-into-main-1725348388
60c2321
to
81f0f8c
Compare
This change is