Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: feature activation in crate Cargo.toml files, not workspace #647

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 28, 2024

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.63%. Comparing base (187dbd5) to head (3a6e716).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
workspace_tests/version_integrity_test.rs 71.42% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #647       +/-   ##
===========================================
- Coverage   91.25%   76.63%   -14.62%     
===========================================
  Files           2      351      +349     
  Lines          80    37151    +37071     
  Branches       80    37151    +37071     
===========================================
+ Hits           73    28471    +28398     
- Misses          6     6366     +6360     
- Partials        1     2314     +2313     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware changed the base branch from main-v0.13.2 to main August 29, 2024 07:53
@dorimedini-starkware dorimedini-starkware force-pushed the dori/features-in-crate-tomls branch from 0503dcb to 0923a38 Compare August 29, 2024 07:54
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Papyrus-wise :lgtm:
Need to make sure with other crate owners.

Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @nadin-Starkware)


Cargo.toml line 168 at r1 (raw file):

regex = "1.10.4"
replace_with = "0.1.7"
reqwest = "0.11"

Is it used? Remove altogether?

Code quote:

reqwest = "0.11"

Cargo.toml line 181 at r1 (raw file):

starknet-core = "0.6.0"
starknet-crypto = "0.5.1"
starknet-types-core = { version = "0.1.5", features = ["hash", "prime-bigint", "std"] }

Are these used?

Code quote:

"prime-bigint", "std"] 

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should they check?

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @nadin-Starkware)


Cargo.toml line 168 at r1 (raw file):

Previously, dan-starkware wrote…

Is it used? Remove altogether?

used in several crates, why do you say it's unused?


Cargo.toml line 181 at r1 (raw file):

Previously, dan-starkware wrote…

Are these used?

doens't look like it.
I ran cargo test -p X for every workspace member X, all passed...

Copy link
Contributor

@uriel-starkware uriel-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r1.
Reviewable status: 1 of 9 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry, @dan-starkware, @elintul, @giladchase, @nadin-Starkware, and @noaov1)

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 9 files at r1.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry, @dan-starkware, @elintul, @giladchase, @nadin-Starkware, and @noaov1)

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry, @elintul, @giladchase, @nadin-Starkware, and @noaov1)

Copy link
Contributor

@uriel-starkware uriel-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry, @elintul, @giladchase, @nadin-Starkware, and @noaov1)

@dorimedini-starkware dorimedini-starkware merged commit 4c4956f into main Sep 3, 2024
28 checks passed
@dorimedini-starkware dorimedini-starkware deleted the dori/features-in-crate-tomls branch September 3, 2024 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants