-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: feature activation in crate Cargo.toml files, not workspace #647
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
===========================================
- Coverage 91.25% 76.63% -14.62%
===========================================
Files 2 351 +349
Lines 80 37151 +37071
Branches 80 37151 +37071
===========================================
+ Hits 73 28471 +28398
- Misses 6 6366 +6360
- Partials 1 2314 +2313 ☔ View full report in Codecov by Sentry. |
0503dcb
to
0923a38
Compare
Signed-off-by: Dori Medini <[email protected]>
0923a38
to
3a6e716
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Papyrus-wise
Need to make sure with other crate owners.
Reviewable status: 0 of 9 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @nadin-Starkware)
Cargo.toml
line 168 at r1 (raw file):
regex = "1.10.4" replace_with = "0.1.7" reqwest = "0.11"
Is it used? Remove altogether?
Code quote:
reqwest = "0.11"
Cargo.toml
line 181 at r1 (raw file):
starknet-core = "0.6.0" starknet-crypto = "0.5.1" starknet-types-core = { version = "0.1.5", features = ["hash", "prime-bigint", "std"] }
Are these used?
Code quote:
"prime-bigint", "std"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what should they check?
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @nadin-Starkware)
Cargo.toml
line 168 at r1 (raw file):
Previously, dan-starkware wrote…
Is it used? Remove altogether?
used in several crates, why do you say it's unused?
Cargo.toml
line 181 at r1 (raw file):
Previously, dan-starkware wrote…
Are these used?
doens't look like it.
I ran cargo test -p X
for every workspace member X
, all passed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 9 files at r1.
Reviewable status: 1 of 9 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry, @dan-starkware, @elintul, @giladchase, @nadin-Starkware, and @noaov1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 9 files at r1.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry, @dan-starkware, @elintul, @giladchase, @nadin-Starkware, and @noaov1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 9 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry, @elintul, @giladchase, @nadin-Starkware, and @noaov1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry, @elintul, @giladchase, @nadin-Starkware, and @noaov1)
This change is