-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move from once_cell Lazy to LazyLock #571
Conversation
09d58d7
to
eca93d9
Compare
Benchmark movements: |
Benchmark movements: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 76.59% 76.57% -0.03%
==========================================
Files 348 348
Lines 36771 36771
Branches 36771 36771
==========================================
- Hits 28166 28156 -10
- Misses 6281 6290 +9
- Partials 2324 2325 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dori Medini <[email protected]>
eca93d9
to
c1f53bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @giladchase)
Dockerfile
line 10 at r2 (raw file):
# We start by creating a base image using 'clux/muslrust' with additional required tools. FROM clux/muslrust:1.80.0-stable AS chef
@dan-starkware @nadin-Starkware is this ok?
Code quote:
1.80.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 13 files reviewed, all discussions resolved (waiting on @giladchase)
Dockerfile
line 10 at r2 (raw file):
Previously, dorimedini-starkware wrote…
@dan-starkware @nadin-Starkware is this ok?
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:hat_tip:
Reviewed 12 of 12 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
This change is