Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move from once_cell Lazy to LazyLock #571

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Aug 22, 2024

This change is Reviewable

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [47.751 ms 47.811 ms 47.881 ms]
change: [+1.3555% +1.5323% +1.7123%] (p = 0.00 < 0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
3 (3.00%) high mild
1 (1.00%) high severe

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.457 ms 65.564 ms 65.698 ms]
change: [-7.7137% -4.2714% -1.3946%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) high mild
5 (5.00%) high severe

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.57%. Comparing base (0486b70) to head (c1f53bd).
Report is 6 commits behind head on main.

Files Patch % Lines
crates/starknet_api/src/transaction_hash.rs 40.00% 3 Missing ⚠️
crates/papyrus_execution/src/lib.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   76.59%   76.57%   -0.03%     
==========================================
  Files         348      348              
  Lines       36771    36771              
  Branches    36771    36771              
==========================================
- Hits        28166    28156      -10     
- Misses       6281     6290       +9     
- Partials     2324     2325       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @giladchase)


Dockerfile line 10 at r2 (raw file):

# We start by creating a base image using 'clux/muslrust' with additional required tools.
FROM clux/muslrust:1.80.0-stable AS chef

@dan-starkware @nadin-Starkware is this ok?

Code quote:

1.80.0

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 13 files reviewed, all discussions resolved (waiting on @giladchase)


Dockerfile line 10 at r2 (raw file):

Previously, dorimedini-starkware wrote…

@dan-starkware @nadin-Starkware is this ok?

yes

Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:hat_tip:

:lgtm:

Reviewed 12 of 12 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit 81075ad into main Aug 25, 2024
28 checks passed
@dorimedini-starkware dorimedini-starkware deleted the dori/remove-oncecell-lazy branch August 25, 2024 07:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants