-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(fee): remove more occurnces of resource mapping #547
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nimrod-starkware and the rest of your teammates on Graphite |
02f7ec8
to
eec363c
Compare
9213b8f
to
42998e5
Compare
eec363c
to
d1f5d45
Compare
42998e5
to
ac10dbc
Compare
d1f5d45
to
4b7f6f4
Compare
ac10dbc
to
dbb4233
Compare
4b7f6f4
to
995c2db
Compare
dbb4233
to
bd1181a
Compare
995c2db
to
24d611b
Compare
bd1181a
to
f3c04ae
Compare
24d611b
to
2ce1278
Compare
f3c04ae
to
85cf607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @ShahakShama)
crates/papyrus_storage/src/serialization/serializers.rs
line 369 at r1 (raw file):
pub max_amount: u64, pub max_price_per_unit: u128, }
2ce1278
to
2bf3583
Compare
85cf607
to
f92c17b
Compare
2bf3583
to
c578a3f
Compare
f92c17b
to
0fc7eae
Compare
c578a3f
to
67d9f1c
Compare
0fc7eae
to
c27e3e9
Compare
67d9f1c
to
9eeb7ba
Compare
c27e3e9
to
68faa71
Compare
9eeb7ba
to
c7722e6
Compare
e122e41
to
69e2d09
Compare
49c75ef
to
a1450e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @ShahakShama)
69e2d09
to
deed29a
Compare
a1450e0
to
3a77da9
Compare
deed29a
to
33dc05a
Compare
3a77da9
to
2153557
Compare
33dc05a
to
0a4a144
Compare
2153557
to
ed50e99
Compare
0a4a144
to
6aec949
Compare
ed50e99
to
db8074f
Compare
Benchmark movements: |
Benchmark movements: |
6aec949
to
9745223
Compare
db8074f
to
70b5a37
Compare
70b5a37
to
a64e601
Compare
Benchmark movements: |
a64e601
to
f35a01b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r7, all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @nimrod-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r7.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/papyrus_storage/src/serialization/serializers.rs
line 369 at r1 (raw file):
Previously, dorimedini-starkware wrote…
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 1 of 3 files at r2, 1 of 2 files at r3, 1 of 1 files at r5, 1 of 1 files at r6, 1 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @dorimedini-starkware from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
This change is