Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: define try from snapi executable transaction for account tx #526

Merged
merged 1 commit into from
Aug 20, 2024
Merged

chore: define try from snapi executable transaction for account tx #526

merged 1 commit into from
Aug 20, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 20, 2024 •
edited by Yoni-Starkware
Loading

This change is Reviewable

This was referenced Aug 20, 2024
Merged
Merged
@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Aug 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review August 20, 2024 07:23
dafnamatsry
dafnamatsry approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

@ArniStarkware ArniStarkware force-pushed the arni/refactor/account_tx_wrapper/invoke branch from a553ba4 to f23134e Compare August 20, 2024 11:35
@ArniStarkware ArniStarkware force-pushed the arni/refactor/account_tx_wrapper/snapi_executable_tx_try_into_account_tx branch from 1bc52f7 to e524a3a Compare August 20, 2024 11:35
@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Aug 20, 2024 •
edited
Loading

Merge activity

@ArniStarkware ArniStarkware changed the base branch from arni/refactor/account_tx_wrapper/invoke to graphite-base/526 August 20, 2024 12:37
@ArniStarkware ArniStarkware changed the base branch from graphite-base/526 to main August 20, 2024 12:48
@ArniStarkware ArniStarkware force-pushed the arni/refactor/account_tx_wrapper/snapi_executable_tx_try_into_account_tx branch from e524a3a to 15d22a6 Compare August 20, 2024 12:49
@ArniStarkware ArniStarkware merged commit 1487474 into main Aug 20, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@ArniStarkware ArniStarkware deleted the arni/refactor/account_tx_wrapper/snapi_executable_tx_try_into_account_tx branch September 22, 2024 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dafnamatsry dafnamatsry dafnamatsry approved these changes

@MohammadNassar1 MohammadNassar1 Awaiting requested review from MohammadNassar1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArniStarkware @dafnamatsry