Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): missing multiaddr import #497

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

eitanm-starkware
Copy link
Contributor

@eitanm-starkware eitanm-starkware commented Aug 18, 2024

This change is Reviewable

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.78%. Comparing base (07e89e4) to head (07c570f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
+ Coverage   76.77%   76.78%   +0.01%     
==========================================
  Files         348      348              
  Lines       36284    36316      +32     
  Branches    36284    36316      +32     
==========================================
+ Hits        27856    27885      +29     
- Misses       6134     6136       +2     
- Partials     2294     2295       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eitanm-starkware eitanm-starkware merged commit f6fadee into main Aug 18, 2024
40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@eitanm-starkware eitanm-starkware deleted the sequencer-2 branch December 23, 2024 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants